Refactor TensorNetwork type; add NormNetwork struct. #119
Open
jack-dunham wants to merge 112 commits into
Open
Refactor TensorNetwork type; add NormNetwork struct. #119jack-dunham wants to merge 112 commits into
TensorNetwork type; add NormNetwork struct. #119jack-dunham wants to merge 112 commits into
Conversation
Introduce `BeliefPropagationProblem` wrapper to hold the cache and the error `diff` field. Also simplifies some kwargs wrangling.
…be set from another cache
Also includes some fixes to the way `TensorNetwork` types are constructed based on index structure.
for more information, see https://pre-commit.ci
…instead of trying to operate on existing graphs The reason for this is: - One only cares about the edges of the input graph - A simple graph cannot be used as it "forgets" its edge names resulting in recursion - As shown with `TensorNetwork`, removing edges may not always be defined.
…s from an array.
This was caused by the change to the `cache` being backed by a directed graph.
1310cc2 to
7c51b20
Compare
mtfishman
reviewed
Jun 16, 2026
mtfishman
reviewed
Jun 16, 2026
mtfishman
reviewed
Jun 16, 2026
mtfishman
reviewed
Jun 16, 2026
mtfishman
reviewed
Jun 16, 2026
mtfishman
reviewed
Jun 16, 2026
mtfishman
reviewed
Jun 16, 2026
Defaults to one constructed via `randname`.
for more information, see https://pre-commit.ci
mtfishman
reviewed
Jun 24, 2026
This local refers to a index name not an index itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
TensorNetworkdata type to include a reverse index map, and to be stricter about it's construction and how it's tensors can be set.This PR also adds
NormNetworktype, as a wrapper around aTensorNetwork, to represent the norm of a tensor network.